Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-12 Thread Andrew Fish via groups.io
> On Aug 12, 2021, at 12:26 AM, Marvin Häuser wrote: > > On 11/08/2021 19:19, Andrew Fish wrote: >> >> >>> On Aug 11, 2021, at 1:11 AM, Marvin Häuser >> > wrote: >>> >>> On 10/08/2021 23:58, Andrew Fish wrote: > On Aug 10, 2021, at 2:30 PM, Marvin Häuser

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-12 Thread Marvin Häuser
On 12/08/2021 09:26, Marvin Häuser wrote: The value of p is constant, so it can be placed in a constant data section. p points to a global variable, so if the compiler does not manage to somehow turn this into relative addressing (let's assume it does not), it needs to generate a relocation. Th

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-12 Thread Marvin Häuser
On 11/08/2021 19:19, Andrew Fish wrote: On Aug 11, 2021, at 1:11 AM, Marvin Häuser > wrote: On 10/08/2021 23:58, Andrew Fish wrote: On Aug 10, 2021, at 2:30 PM, Marvin Häuser > wrote: On 10/08/2021 21:35, Andrew Fish via groups.io

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-11 Thread Marvin Häuser
On 10/08/2021 23:58, Andrew Fish wrote: On Aug 10, 2021, at 2:30 PM, Marvin Häuser wrote: On 10/08/2021 21:35, Andrew Fish via groups.io wrote: On Aug 10, 2021, at 1:27 AM, Marvin Häuser mailto:mhaeu...@posteo.de>> wrote: On 10/08/2021 06:19, Andrew Fish via groups.io w

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Andrew Fish via groups.io
> On Aug 10, 2021, at 2:30 PM, Marvin Häuser wrote: > > On 10/08/2021 21:35, Andrew Fish via groups.io wrote: >> >> >>> On Aug 10, 2021, at 1:27 AM, Marvin Häuser >> > wrote: >>> >>> On 10/08/2021 06:19, Andrew Fish via groups.io wrote: >>

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Andrew Fish via groups.io
> On Aug 10, 2021, at 2:24 PM, Marvin Häuser wrote: > > On 10/08/2021 21:49, Andrew Fish wrote: >> I forgot I have an Ubuntu VM so we can take a look at an ELF to PE/COFF >> toolchain example …. >> >> So it looks like nasm[1] “does the right thing”(tm) and places a .rodata >> section in th

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Marvin Häuser
On 10/08/2021 21:35, Andrew Fish via groups.io wrote: On Aug 10, 2021, at 1:27 AM, Marvin Häuser > wrote: On 10/08/2021 06:19, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 2:51 AM, Marvin Häuser

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Marvin Häuser
On 10/08/2021 21:49, Andrew Fish wrote: I forgot I have an Ubuntu VM so we can take a look at an ELF to PE/COFF  toolchain example …. So it looks like nasm[1] “does the right thing”(tm) and places a .rodata section in the object file…. But it looks like GenFw[2] smashed the .rodata section i

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Andrew Fish via groups.io
> On Aug 10, 2021, at 1:27 AM, Marvin Häuser wrote: > > On 10/08/2021 06:19, Andrew Fish via groups.io wrote: >> >> >>> On Aug 9, 2021, at 2:51 AM, Marvin Häuser >> > wrote: >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 >>>

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-10 Thread Marvin Häuser
On 10/08/2021 06:19, Andrew Fish via groups.io wrote: On Aug 9, 2021, at 2:51 AM, Marvin Häuser > wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 Different toolchains of the EDK II build system

Re: [edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-09 Thread Andrew Fish via groups.io
> On Aug 9, 2021, at 2:51 AM, Marvin Häuser wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 > > Different toolchains of the EDK II build system may generate ELF or > Mach-O files, which use the ".rodata" naming convention, or PE/COFF > files, which use the ".rdata" naming c

[edk2-devel] [PATCH v2 1/2] BaseTools: Define the read-only data section name per toolchain

2021-08-09 Thread Marvin Häuser
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3318 Different toolchains of the EDK II build system may generate ELF or Mach-O files, which use the ".rodata" naming convention, or PE/COFF files, which use the ".rdata" naming convention. Section permissions are chosen based on this name per fi