Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

2024-01-26 Thread Gerd Hoffmann
On Fri, Jan 26, 2024 at 02:49:13AM +, Liu, Zhiguang wrote: > Hi Gerd, > For the PCD, it current has below usage. > 1) for 32-bit PEI and 64-bit DXE, this PCD will decide if use 5 level paging > in DXE. Yes. That is the only real use of the PCD today. I expect the days of 32bit BEI / 64bit

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

2024-01-25 Thread Zhiguang Liu
er Steffen > Subject: Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename > PcdUse5LevelPageTable to PcdEnable5LevelPageTable > > On Thu, Jan 25, 2024 at 12:01:46PM +, Ni, Ray wrote: > > Rename an existing PCD might break lots of platform builds. > > > > When 5-

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

2024-01-25 Thread Gerd Hoffmann
On Thu, Jan 25, 2024 at 12:01:46PM +, Ni, Ray wrote: > Rename an existing PCD might break lots of platform builds. > > When 5-level paging capability was added to ResetVector, I also > considered to remove the PcdUse5LevelPageTable reference from C code. > > Let me think about it... Purging

Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

2024-01-25 Thread Ni, Ray
ups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, January 25, 2024 4:21 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; László Érsek > ; Oliver Steffen ; Gerd Hoffmann > > Subject: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename > PcdUse5LevelPageTable to PcdEnable5LevelPag

[edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable

2024-01-25 Thread Gerd Hoffmann
The PCD will allow but not require 5-level paging. Whenever 5-level paging is used or not will be decided by the ResetVector, by looking at CPU capabilities. Rename the PCD to make that clear. Signed-off-by: Gerd Hoffmann --- MdeModulePkg/MdeModulePkg.dec| 2 +-