Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-09 Thread Rebecca Cran
On 2/7/23 01:20, Michael Brown wrote: Is PcdGet32() guaranteed to be a compile-time constant?  If not, then it's probably a good idea to read it once upon initialisation, rather than once per timer interrupt handler invocation. There's an explicit compile-time version, FixedPcdGet32. -- Rebe

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-08 Thread RichardHo [何明忠] via groups . io
) Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support [rebe...@bsdio.com appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-08 Thread RichardHo [何明忠] via groups . io
] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On 2/7/2023 3:20 PM, Michael Brown wrote: > On 07/02/2023 06:21, Tinh Nguyen via groups.io wr

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Tinh Nguyen via groups.io
On 2/7/2023 3:20 PM, Michael Brown wrote: > On 07/02/2023 06:21, Tinh Nguyen via groups.io wrote: >> From: Tinh Nguyen >> Date: Tue, 7 Feb 2023 12:43:17 +0700 >> Subject: [PATCH] UsbNetworkPkg: Support rate limitting >> >> Signed-off-by: Tinh Nguyen > > Thank you for extending my patch to add the

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Rebecca Cran
On 2/4/23 01:54, RichardHo [何明忠] via groups.io wrote: diff --git a/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h b/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h new file mode 100644 index 00..629c83e24e --- /dev/null +++ b/UsbNetworkPkg/Include/Protocol/EdkIIUsbE

Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-02-07 Thread Michael Brown
On 07/02/2023 06:21, Tinh Nguyen via groups.io wrote: From: Tinh Nguyen Date: Tue, 7 Feb 2023 12:43:17 +0700 Subject: [PATCH] UsbNetworkPkg: Support rate limitting Signed-off-by: Tinh Nguyen Thank you for extending my patch to add the PCD support. The overall patch appears still to be subs