Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-19 Thread Anthony PERARD via groups.io
On Fri, Aug 13, 2021 at 02:13:01PM +0800, Gary Lin wrote: > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since > InitializeXenPlatform() didn't set

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-16 Thread Lin, Gary (HPS OE-Linux)
On Mon, Aug 16, 2021 at 09:07:01AM +0200, Ard Biesheuvel wrote: > Does this series have a cover letter? > Sorry, I forgot to add Cc tags in the cover letter. https://edk2.groups.io/g/devel/topic/84857762#79245 Gary Lin > On Fri, 13 Aug 2021 at 08:13, Lin, Gary (HPS OE-Linux) > wrote: > > > >

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-16 Thread Ard Biesheuvel
Does this series have a cover letter? On Fri, 13 Aug 2021 at 08:13, Lin, Gary (HPS OE-Linux) wrote: > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since >

[edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-13 Thread Lin, Gary (HPS OE-Linux)
There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency