Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

2020-03-25 Thread Ashish Singhal
Hi Ard, I tried to verify the patch just now and now I am seeing data abort with a translation fault at 0th level. Also, if this helps, it is caused by in FreePageTablesRecursive function when it tries to access the address pointed to by TranslationTable. Thanks Ashish

Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

2020-03-25 Thread Ard Biesheuvel
On Wed, 25 Mar 2020 at 13:38, Leif Lindholm wrote: > > On Wed, Mar 25, 2020 at 12:38:46 +0100, Ard Biesheuvel wrote: > > Currently, depending on the size of the region being (re)mapped, the > > page table manipulation code may replace a table entry with a block entry, > > even if the existing tabl

Re: [edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

2020-03-25 Thread Leif Lindholm
On Wed, Mar 25, 2020 at 12:38:46 +0100, Ard Biesheuvel wrote: > Currently, depending on the size of the region being (re)mapped, the > page table manipulation code may replace a table entry with a block entry, > even if the existing table entry uses different mapping attributes to > describe differ

[edk2-devel] [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when replacing a table entry

2020-03-25 Thread Ard Biesheuvel
Currently, depending on the size of the region being (re)mapped, the page table manipulation code may replace a table entry with a block entry, even if the existing table entry uses different mapping attributes to describe different parts of the region it covers. This is undesirable, and instead, w