Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2022-10-14 Thread Sami Mujawar
Hi Oliver, Thank you for the updated patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 14/10/2022 01:34 pm, Oliver Steffen wrote: ArmVirtXen.dsc initializes gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with with the value of the variable "FIRMWARE_VER". Move that functio

[edk2-devel] [PATCH v2 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2022-10-14 Thread Oliver Steffen
ArmVirtXen.dsc initializes gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with with the value of the variable "FIRMWARE_VER". Move that functionality to ArmVirt.dsc.inc to make it available to all ArmVirt packages, and make it conditional: only set the PCD string if FIRMWARE_VER is actual