Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2023-10-03 Thread Philippe Mathieu-Daudé
Hi Leif, On 26/9/23 19:15, Leif Lindholm wrote: There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/Ba

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2023-10-03 Thread Leif Lindholm
On Mon, Oct 02, 2023 at 20:00:21 +0200, Philippe Mathieu-Daudé wrote: > Hi Leif, > > On 26/9/23 19:15, Leif Lindholm wrote: > > There may be architectures on which there are benefits to > >eor r0, r0(, r0) > > but ARM was never one of them. Change to more readable > >mov r0, #0 > > instead

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2023-09-29 Thread Sami Mujawar
Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readabl

[edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2023-09-26 Thread Leif Lindholm
There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- MdePkg/Library/B