Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2023-10-03 Thread Philippe Mathieu-Daudé
On 26/9/23 19:15, Leif Lindholm wrote: Both in SetJump and in InternalLongJump, 32-bit w register views were used for the UINTN return value. In SetJump, this did not cause errors; it was only counterintuitive. But in InternalLongJump, it meant the top 32 bits of Value were stripped off. Change

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2023-09-29 Thread Andrei Warkentin
Reviewed-by: Andrei Warkentin От: Leif Lindholm Отправлено: вторник, сентября 26, 2023 12:16 PM Кому: devel@edk2.groups.io Копия: Philippe Mathieu-Daudé ; Warkentin, Andrei ; Ard Biesheuvel ; Sami Mujawar Тема: [PATCH v2 4/5] MdePkg/BaseLib: correct register s

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2023-09-29 Thread Sami Mujawar
Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: Both in SetJump and in InternalLongJump, 32-bit w register views were used for the UINTN return value. In SetJump, this did not cau

[edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2023-09-26 Thread Leif Lindholm
Both in SetJump and in InternalLongJump, 32-bit w register views were used for the UINTN return value. In SetJump, this did not cause errors; it was only counterintuitive. But in InternalLongJump, it meant the top 32 bits of Value were stripped off. Change all of these to use the 64-bit x register