fmann
>> Sent: Thursday, February 22, 2024 8:29 PM
>> To: Laszlo Ersek
>> Cc: devel@edk2.groups.io; Oliver Steffen ; Kumar,
>> Rahul R ; Ni, Ray
>> Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support
>> for multiple HOBs to MpInit
Cc: devel@edk2.groups.io; Oliver Steffen ; Kumar,
> Rahul R ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support
> for multiple HOBs to MpInitLibInitialize
>
> Hi,
>
> > The code looks otherwise OK, but I'm not happy that
> >
Hi,
> The code looks otherwise OK, but I'm not happy that
> WaitLoopExecutionMode (and StartupSignalValue) are replicated over all
> the HOBs, just like in v1. IMO, that will only make it harder for others
> to understand the code / data structures, and therefore it increases
> technical debt.
On 2/20/24 18:49, Gerd Hoffmann wrote:
> Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
> covering all CPUs in the system.
>
> Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are
> present, using the MpHandOff pointer for that does not work because the
>
>
> Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
> covering all CPUs in the system.
>
> Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs
> are
The commit message may need to be updated as "HaveMpHandOff" variable is gone
in this version.
With that,
Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
covering all CPUs in the system.
Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are
present, using the MpHandOff pointer for that does not work because the
variable will be NULL after looping over all HOBs.
