Re: [edk2-devel] [PATCH v2 5/6] SecurityPkg: Add new modules to Security package.

2021-06-04 Thread Sunny Wang
Internally reviewed this patch before sending the edk2 mailing list and It looks good to me. Please also address Pete's good catches/comments. Reviewed-by: Sunny Wang -Original Message- From: Grzegorz Bernacki Sent: Tuesday, June 1, 2021 9:12 PM To: devel@edk2.groups.io Cc: l...@nuviain

Re: [edk2-devel] [PATCH v2 5/6] SecurityPkg: Add new modules to Security package.

2021-06-04 Thread Min Xu
On June 1, 2021 9:12 PM, Grzegorz Bernacki Wrote: > This commits adds modules related to initialization and usage of default > Secure Boot key variables to SecurityPkg. > > Signed-off-by: Grzegorz Bernacki > --- > SecurityPkg/SecurityPkg.dec | 14 ++ > SecurityPkg/SecurityPkg.dsc | 4

Re: [edk2-devel] [PATCH v2 5/6] SecurityPkg: Add new modules to Security package.

2021-06-02 Thread Pete Batard
One very minor remark: On 2021.06.01 14:12, Grzegorz Bernacki wrote: This commits adds modules related to initialization and usage of default Secure Boot key variables to SecurityPkg. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/SecurityPkg.dec | 14 ++ SecurityPkg/SecurityP

[edk2-devel] [PATCH v2 5/6] SecurityPkg: Add new modules to Security package.

2021-06-01 Thread Grzegorz Bernacki
This commits adds modules related to initialization and usage of default Secure Boot key variables to SecurityPkg. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/SecurityPkg.dec | 14 ++ SecurityPkg/SecurityPkg.dsc | 4 2 files changed, 18 insertions(+) diff --git a/Security