Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.

2022-07-22 Thread Nate DeSimone
Good catch everyone! The spec has been changed to the following: typedef struct { UINT8Revision; UINT8Reserved[3]; UINT32 Length; EFI_PHYSICAL_ADDRESS BootloaderSmmFvBaseAddress; UINT64 BootloaderSmmFvLength; EFI_PHYSICAL_ADDRESS Bootloa

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.

2022-07-20 Thread Zeng, Star
The spec looks wrong to me. Thanks, Star -Original Message- From: Chiu, Chasel Sent: Thursday, July 21, 2022 11:16 AM To: Zeng, Star ; devel@edk2.groups.io Cc: Desimone, Nathaniel L Subject: RE: [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Hi Star, this is following current specificati

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.

2022-07-20 Thread Chiu, Chasel
Hi Star, this is following current specification. Thanks, Chasel > -Original Message- > From: Zeng, Star > Sent: Wednesday, July 20, 2022 8:07 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH

Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.

2022-07-20 Thread Zeng, Star
Is the reserved bytes number correct for FSPI_ARCH_UPD alignment? UINT16 BootloaderSmmFvContextDataLength; UINT8Reserved1[24]; Thanks, Star -Original Message- From: Chiu, Chasel Sent: Thursday, July 21, 2022 10:29 AM To: devel@edk2.groups.io Cc: Chiu, Chase

[edk2-devel] [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.

2022-07-20 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993 Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up, and some comments for clarification. Also fixed a bug in SplitFspBin.py for FSP-I support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pk