Patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/ae75c51f27e21036b6ee021a2d5b9f365f951413
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ;
Hi Aryeh,
Thank you for testing.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, September 21, 2022 12:34 AM
> To: Sinha, Ankit ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
>
Hi Ankit,
Add a change to remove Name(_ADR, 0x) from
edk2-platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl
It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU openboard
bios.
=== Acpidump ===
Signature "DSDT"
Length 0x00FD (253)
Revision
Hi Aryeh,
Can you please post the test results for this change. It would be good to note
that there is no change in behavior in the OS.
Thank you,
Ankit
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ;
Sent: Monday, September 12, 2022 1:33 AM
> To: Chen, Aryeh
> Cc: devel@edk2.groups.io; Chiu, Chasel ; Desimone,
> Nathaniel L ; Oram, Isaac W
> ; Sinha, Ankit ; Gao,
> Liming ; Dong, Eric
> Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from
> MinDsdt.asl
On Mon, 12 Sep 2022 13:17:45 +0800
aryeh.c...@intel.com wrote:
> From: Aryeh Chen
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
>
> According to ASL Coding Guidelines - Device Identifiers
> "A Device should contain either an _ADR or a _HID object, never both."
> , so remove _ADR
From: Aryeh Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
According to ASL Coding Guidelines - Device Identifiers
"A Device should contain either an _ADR or a _HID object, never both."
, so remove _ADR due to _HID exist.
Signed-off-by: Aryeh Chen
Cc: Chasel Chiu
Cc: Nate
