Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-23 Thread Gerd Hoffmann
> +++ b/OvmfPkg/XenPlatformPei/Platform.c > + // > + // This S3 conditional test is mainly for HVM Direct Kernel Boot since > + // QEMU fwcfg isn't really supported other than that. > + // > + if (QemuFwCfgS3Enabled ()) { > +DEBUG ((DEBUG_INFO, "S3 support was detected on QEMU\n")); > +

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-23 Thread Anthony PERARD via groups.io
On Mon, Aug 23, 2021 at 03:09:22PM +0800, Gary Lin wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support.

[edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

2021-08-23 Thread Lin, Gary (HPS OE-Linux)
https://bugzilla.tianocore.org/show_bug.cgi?id=3573 There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as Initiali