Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2023-01-12 Thread Michael Kubacki
On 1/11/2023 11:23 AM, Ard Biesheuvel wrote: Your feedback is still valuable to the wider TianoCore Tools & CI group that meets weekly. It may be able to be addressed there. Those tend to take place in the middle of the night for me, which is why I rarely join those. The meeting time has been

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2023-01-11 Thread Ard Biesheuvel
On Fri, 6 Jan 2023 at 03:46, Michael Kubacki wrote: > > Hi Ard, > > I believe you're referencing the points in this mail, right? > https://edk2.groups.io/g/devel/message/97433 > > To be clear about why that was considered dismissive and passive > aggressive, these sentences: > > "I would also like

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2023-01-05 Thread Michael Kubacki
Hi Ard, I believe you're referencing the points in this mail, right? https://edk2.groups.io/g/devel/message/97433 To be clear about why that was considered dismissive and passive aggressive, these sentences: "I would also like to point out that all this focus on code aesthetics that do not co

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2023-01-04 Thread Ard Biesheuvel
On Thu, 15 Dec 2022 at 17:38, Michael Kubacki wrote: > > On 12/15/2022 5:42 AM, Leif Lindholm wrote: > > On Wed, Dec 14, 2022 at 19:04:06 -0500, Michael Kubacki wrote: > >> I'm just trying to understand your position. > >> > >> Are you saying you would rather people check in typos and then later h

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-16 Thread Michael Kubacki
jawar ; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode On 12/15/2022 5:42 AM, Leif Lindholm wrote: On Wed, Dec 14, 2022 at 19:04:06 -0500, Michael Kubacki wrote: I'm just trying to understand your position. Are you saying you would rat

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-15 Thread Michael D Kinney
Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Thursday, December 15, 2022 8:39 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com > Cc: a...@kernel.org; Ard Biesheuvel ; Sami Mujawar > ; Kinney, Michael D > > Subj

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-15 Thread Leif Lindholm
On Wed, Dec 14, 2022 at 19:04:06 -0500, Michael Kubacki wrote: > I'm just trying to understand your position. > > Are you saying you would rather people check in typos and then later have > patches come into the package to fix them? > > For example, like these: > > - ArmVirtPkg: https://edk2.gro

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-15 Thread Ard Biesheuvel
On Thu, 15 Dec 2022 at 01:04, Michael Kubacki wrote: > > I'm just trying to understand your position. > > Are you saying you would rather people check in typos and then later > have patches come into the package to fix them? > > For example, like these: > > - ArmVirtPkg: https://edk2.groups.io/g/d

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-14 Thread Ard Biesheuvel
On Thu, 15 Dec 2022 at 00:21, Michael Kubacki wrote: > > Yes. It will also reduce frequency of incoming patches that must be > reviewed and merged due to people continuously fixing trivial spelling > errors. > In that case, NAK to this patch (and the ArmVirtPkg one). Unless we add a button to the

Re: [edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-14 Thread Ard Biesheuvel
On Wed, 14 Dec 2022 at 23:53, wrote: > > From: Michael Kubacki > > Audit mode was enabled for the spellcheck CI plugin. It is no longer > needed with recent changes. Spelling errors can be checked in the > package moving forward. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar >

[edk2-devel] [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode

2022-12-14 Thread Michael Kubacki
From: Michael Kubacki Audit mode was enabled for the spellcheck CI plugin. It is no longer needed with recent changes. Spelling errors can be checked in the package moving forward. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Michael Kubacki --- ArmPkg/ArmPkg.ci.yaml