Re: [edk2-devel] [PATCH v3 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation

2024-01-18 Thread Rebecca Cran via groups.io
On 1/5/2024 1:26 AM, Ard Biesheuvel wrote: @@ -91,7 +88,8 @@ WatchdogExitBootServicesEvent ( ) { WatchdogDisable (); - mNumTimerTicks = 0; + mTimerPeriod= 0; + mExitedBootServices = TRUE; Where is this declared/defined? Oh, it's defined in the 3rd patch - which

Re: [edk2-devel] [PATCH v3 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation

2024-01-05 Thread Sami Mujawar
Hi Rebecca, I have a minor suggestion marked inline as [SAMI], otherwise this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/01/2024, 05:15, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote: The calculation of the timer period was broken.

Re: [edk2-devel] [PATCH v3 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation

2024-01-05 Thread Ard Biesheuvel
On Fri, 5 Jan 2024 at 06:15, Rebecca Cran wrote: > > The calculation of the timer period was broken. Introduce a global > mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz > is only used in one place, remove the global and make it a local > variable. Do the same with

[edk2-devel] [PATCH v3 2/3] ArmPkg: Introduce global mTimerPeriod and remove calculation

2024-01-04 Thread Rebecca Cran via groups.io
The calculation of the timer period was broken. Introduce a global mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz is only used in one place, remove the global and make it a local variable. Do the same with mNumTimerTicks. Signed-off-by: Rebecca Cran ---