On 1/23/24 18:41, Michael Brown wrote:
> On 23/01/2024 16:55, Laszlo Ersek wrote:
>>> + ///
>>> + /// Number of self-tests performed.
>>> + ///
>>> + UINTN SelfTestCount;
>>> } NESTED_INTERRUPT_STATE;
>>> /**
>>
>> I suggest that the new field be UINT32. The (exclusive) limit is a
Thank you for adding the self-test code!
Thanks,
Ray
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, January 24, 2024 6:25 PM
> To: Michael Brown ; devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Laszlo Ersek
> Subject: RE: [PATCH v3 4/5] MdeModulePkg: Add self-tests for
>
> +//
> +// Number of self-tests to perform.
> +//
> +#define NUMBER_OF_SELF_TESTS \
> + (FixedPcdGet32 (PcdNestedInterruptNumberOfSelfTests))
1. can we avoid defining a PCD? I do not see a need that each platform needs
to use a different count. How about just define it as 1?
> +
> +STATIC
>
On 23/01/2024 16:55, Laszlo Ersek wrote:
+ ///
+ /// Number of self-tests performed.
+ ///
+ UINTN SelfTestCount;
} NESTED_INTERRUPT_STATE;
/**
I suggest that the new field be UINT32. The (exclusive) limit is a
32-bit PCD. Making the counter (potentially) wider than the limit
only superficial comments:
On 1/23/24 16:31, Michael Brown wrote:
> Add the ability to perform self-tests on the first few invocations of
> NestedInterruptRestoreTPL(), to verify that:
>
> - the timer interrupt handler correctly rearms the timer interrupt
> before calling
Add the ability to perform self-tests on the first few invocations of
NestedInterruptRestoreTPL(), to verify that:
- the timer interrupt handler correctly rearms the timer interrupt
before calling NestedInterruptRestoreTPL(), and
- the architecture-specific DisableInterruptsOnIret()
