Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Michael Brown
On 23/01/2024 17:10, Laszlo Ersek wrote: Other than that, the patch looks great to me; I'd only propose one (superficial) improvement: rather than include , scavenge #ifdef MDE_CPU_ARM #include #elif defined (MDE_CPU_AARCH64) #include #endif from it. Reasons: (a) Those are the headers

Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Laszlo Ersek
On 1/23/24 16:31, Michael Brown wrote: > The only architecture-specific portion of NestedInterruptTplLib is in > Iret.c, which must manipulate the interrupt stack frame such that the > return-from-interrupt instruction will not re-enable interrupts. The > remaining logic in Tpl.c is

Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Michael Brown
On 23/01/2024 15:51, Ard Biesheuvel wrote: On Tue, 23 Jan 2024 at 16:31, Michael Brown wrote: Add implementations of DisableInterruptsOnIret() for MDE_CPU_ARM and MDE_CPU_AARCH64. In both cases, the saved IRQs-disabled and FIQs-disabled flags are set in the stored processor status register

Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Ard Biesheuvel
On Tue, 23 Jan 2024 at 16:31, Michael Brown wrote: > > The only architecture-specific portion of NestedInterruptTplLib is in > Iret.c, which must manipulate the interrupt stack frame such that the > return-from-interrupt instruction will not re-enable interrupts. The > remaining logic in Tpl.c

[edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Michael Brown
The only architecture-specific portion of NestedInterruptTplLib is in Iret.c, which must manipulate the interrupt stack frame such that the return-from-interrupt instruction will not re-enable interrupts. The remaining logic in Tpl.c is architecture-agnostic. Add implementations of