Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time

2019-12-04 Thread Dong, Eric
Hi Ray, > -Original Message- > From: Ni, Ray > Sent: Thursday, December 5, 2019 1:25 PM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Laszlo Ersek > Subject: RE: [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate > Token every time > > Some comments. > > + // > > > > + // Not free th

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time

2019-12-04 Thread Ni, Ray
Some comments. > + // > > + // Not free the buffer, just clear the UsedTokenNum. In order to > > + // avoid triggering allocate action when we need to use the token, > > + // do not free the buffer. 1. Can you reword to below? "Only free the token buffer recorded in the OldTOkenBufList upon

[edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time

2019-12-04 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 Token is new introduced by MM MP Protocol. Current logic allocate Token every time when need to use it. The logic caused SMI latency raised to very high. Update logic to allocate Token buffer at driver's entry point. Later use the token from