Hi Mike,
Sorry, I only just saw this message.
Your implementation looks better since as you say it doesn't require
updates to the DebugLib instances.
Since you're more familiar with the gotchas around adding this, I'll
leave it to you to decide if this can be committed or not.
--
Rebecca
On 11/10/22 12:11, Kinney, Michael D wrote:
In the edk2 repo, I see the following instances of the DebugPrintMarker() API
where you are currently adding he ANSI color sequences. Should all of these
be updated? I did not review the edk2-platforms repo. And there may be
downstream custom
Hi Rebecca,
Here is an alternate way to implement this feature. Just an
experiment because it does not follow the recommended methods
to add a feature that can be enabled/disabled. I have tested
this on EmulatorPkg and OvmfPkg and it works as expected.
Does not require any updates to any
Hi Rebecca,
In the edk2 repo, I see the following instances of the DebugPrintMarker() API
where you are currently adding he ANSI color sequences. Should all of these
be updated? I did not review the edk2-platforms repo. And there may be
downstream custom DebugLib instances. It would better if
Could I get some reviews on this please?
Thanks.
Rebecca Cran
On 10/27/22 12:51, Rebecca Cran wrote:
There currently isn't a way to differentiate the different
levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO
etc.
To improve this, wrap DEBUG_ERROR and DEBUG_WARN level
messages in
There currently isn't a way to differentiate the different
levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO
etc.
To improve this, wrap DEBUG_ERROR and DEBUG_WARN level
messages in ANSI color code escape sequences. DEBUG_ERROR
messages will be displayed in red text, and DEBUG_WARN
in
