Hi Rebecca,
On 24/01/2024, 19:36, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
On 1/23/2024 7:10 AM, Sami Mujawar wrote:
> @@ -310,6 +318,7 @@ GenericWatchdogEntry (
> {
> EFI_STATUS Status;
> EFI_HANDLE Handle;
> + UINT32 WatchdogIId;
> [SAMI] Minor, the above variable name
On 1/23/2024 7:10 AM, Sami Mujawar wrote:
@@ -310,6 +318,7 @@ GenericWatchdogEntry (
{
EFI_STATUS Status;
EFI_HANDLE Handle;
+ UINT32 WatchdogIId;
[SAMI] Minor, the above variable name should be WatchdogIid to comply with the
coding standard.
I was wondering about the naming, since it's the "
Hi Rebecca,
Thank you for this patch.
Please find my feedback inline marked as [SAMI].
Regards,
Sami Mujawar
On 19/01/2024, 15:46, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writ
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
---
ArmP
