Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-30 Thread Laszlo Ersek
On 1/30/23 16:23, Laszlo Ersek wrote: > Hi Tom, > > On 1/25/23 16:35, Tom Lendacky wrote: >> On 1/25/23 03:11, Gerd Hoffmann wrote: >>> On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote: On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: > Add PlatformAddHobCB() callback

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-30 Thread Laszlo Ersek
Hi Tom, On 1/25/23 16:35, Tom Lendacky wrote: > On 1/25/23 03:11, Gerd Hoffmann wrote: >> On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote: >>> On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: Add PlatformAddHobCB() callback function for use with PlatformScanE820(). It

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-25 Thread Lendacky, Thomas via groups.io
On 1/25/23 09:35, Tom Lendacky wrote: On 1/25/23 03:11, Gerd Hoffmann wrote: On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote: On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: Add PlatformAddHobCB() callback function for use with PlatformScanE820().  It adds HOBs for high

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-25 Thread Lendacky, Thomas via groups.io
On 1/25/23 03:11, Gerd Hoffmann wrote: On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote: On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: Add PlatformAddHobCB() callback function for use with PlatformScanE820(). It adds HOBs for high memory and reservations (low memory is

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-25 Thread Gerd Hoffmann
On Tue, Jan 24, 2023 at 04:33:48PM -0600, Tom Lendacky wrote: > On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: > > Add PlatformAddHobCB() callback function for use with > > PlatformScanE820(). It adds HOBs for high memory and reservations (low > > memory is handled elsewhere because there

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-24 Thread Lendacky, Thomas via groups.io
On 1/17/23 06:16, Gerd Hoffmann via groups.io wrote: Add PlatformAddHobCB() callback function for use with PlatformScanE820(). It adds HOBs for high memory and reservations (low memory is handled elsewhere because there are some special cases to consider). This replaces calls to

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote: > > On 1/17/23 13:16, Gerd Hoffmann wrote: > > + PlatformAddMemoryRangeHob (Base, End); > > +} > > + } > > + > > (2) Still not sure if this empty line is intentional (it may be, you > didn't answer it under the v2 review

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote: > > On 1/17/23 13:16, Gerd Hoffmann wrote: > > Add PlatformAddHobCB() callback function for use with > > PlatformScanE820(). It adds HOBs for high memory and reservations (low > > memory is handled elsewhere because there are some special cases

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Laszlo Ersek
On 1/17/23 13:16, Gerd Hoffmann wrote: > Add PlatformAddHobCB() callback function for use with > PlatformScanE820(). It adds HOBs for high memory and reservations (low > memory is handled elsewhere because there are some special cases to > consider). This replaces calls to

[edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Gerd Hoffmann
Add PlatformAddHobCB() callback function for use with PlatformScanE820(). It adds HOBs for high memory and reservations (low memory is handled elsewhere because there are some special cases to consider). This replaces calls to PlatformScanOrAdd64BitE820Ram() with AddHighHobs = TRUE. Write any