Re: [edk2-devel] [PATCH v5] IntelSiliconPkg-Vtd: A new PMR interface

2019-10-14 Thread Ni, Ray
Evelyn, Your patch is too big. Can you create separate patches with each addressing one purpose? Based on your commit message, I can see at least 4 patches. Detailed comments: 1. Usually the data structure for HOB is put under header files in Include/Guid/ directory. How about

[edk2-devel] [PATCH v5] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-30 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to control PLMR/PHMR regions. It allows silicon code to