On Fri, May 05, 2023 at 08:33:41AM -0600, Rebecca Cran wrote:
> Gerd,
>
>
> Does this series need rework following this discussion, or is it ready to
> merge?
I think we are good to go. The ASSERT suggested by Ard here ...
>
> > > So it would be better to ASSERT() on non-empty GOT, and ignore
Gerd,
Does this series need rework following this discussion, or is it ready
to merge?
--
Rebecca Cran
On 4/21/23 01:46, Marvin Häuser wrote:
On 21. Apr 2023, at 09:21, Ard Biesheuvel wrote:
On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote:
On Fri, Apr 21, 2023 at 06:01:11AM +00
> > Patch #1, adding a linker script assert as suggested by ard, then:
> >
> > * compile + test on my local workstation (fedora 37, gcc 12).
> > * run CI
> > * compile on some older distros:
> > - rhel-8 (gcc 8)
> > - ubuntu-18.04 (gcc 7)
>
> Did you include NOOPT? GCC5 specifies USING_LTO fo
> On 21. Apr 2023, at 09:21, Ard Biesheuvel wrote:
>
> On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote:
>>
>>> On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
>>>
On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
Not needed any more on modern toolchains, they
On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote:
>
> On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
> >
> > > On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
> > >
> > > Not needed any more on modern toolchains, they are better
> > > in not creating a GOT without this trick.
>
> On 21. Apr 2023, at 08:49, Gerd Hoffmann wrote:
>
> On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
>>
On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
>>>
>>> Not needed any more on modern toolchains, they are better
>>> in not creating a GOT without this trick.
>>
>
On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote:
>
> > On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
> >
> > Not needed any more on modern toolchains, they are better
> > in not creating a GOT without this trick.
>
> Hi Gerd,
>
> Thanks! Just out of interest, how did you test
> On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote:
>
> Not needed any more on modern toolchains, they are better
> in not creating a GOT without this trick.
Hi Gerd,
Thanks! Just out of interest, how did you test this and what were the results?
Best regards,
Marvin
>
> Signed-off-by: Gerd
Not needed any more on modern toolchains, they are better
in not creating a GOT without this trick.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/X64/ProcessorBind.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/MdePkg/Include/X64/ProcessorBind.h
b/MdePkg/Include/X64/Proc
