Re: [edk2-devel] [PATCH v5 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-08-30 Thread Guo Dong
Had better read the register first and write register to have a short line and make it more readable. +SerialPortWriteRegister (SerialRegisterBase, R_UART_LCR, (UINT8)(SerialPortReadRegister (SerialRegisterBase, R_UART_LCR, MmioEnable, RegisterStride) | B_UART_LCR_DLAB), MmioEnable,

[edk2-devel] [PATCH v5 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-08-29 Thread Kavya
Add new Serial port library instance that consumes the HOB defined in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support multiple UART's. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya ---