Re: [edk2-devel] [PATCH v5 23/38] EmbeddedPkg/PrePiLib AARCH64: Remap DXE core before execution

2023-03-16 Thread Leif Lindholm
On 2023-03-16 13:50, Ard Biesheuvel wrote: On Thu, 16 Mar 2023 at 14:33, Leif Lindholm wrote: On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote: Deal with DRAM memory potentially being mapped with non-executable permissions, by mapping the DXE core code sections explicitly before l

Re: [edk2-devel] [PATCH v5 23/38] EmbeddedPkg/PrePiLib AARCH64: Remap DXE core before execution

2023-03-16 Thread Ard Biesheuvel
On Thu, 16 Mar 2023 at 14:33, Leif Lindholm wrote: > > On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote: > > Deal with DRAM memory potentially being mapped with non-executable > > permissions, by mapping the DXE core code sections explicitly before > > launch. > > Could you add a note

Re: [edk2-devel] [PATCH v5 23/38] EmbeddedPkg/PrePiLib AARCH64: Remap DXE core before execution

2023-03-16 Thread Leif Lindholm
On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote: > Deal with DRAM memory potentially being mapped with non-executable > permissions, by mapping the DXE core code sections explicitly before > launch. Could you add a note about why LoadPeCoffImage/LoadDxeCoreFromFfsFile are made private

[edk2-devel] [PATCH v5 23/38] EmbeddedPkg/PrePiLib AARCH64: Remap DXE core before execution

2023-03-13 Thread Ard Biesheuvel
Deal with DRAM memory potentially being mapped with non-executable permissions, by mapping the DXE core code sections explicitly before launch. Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Include/Library/PrePiLib.h | 16 -- EmbeddedPkg/Library/PrePiLib/Arm/RemapDxeCore.c | 51