Re: [edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-21 Thread Chris Fernald
There is probably value in having both if we want to support various flavors of containers in the future, but yes adding a container option to the template similar to vm_image. Thanks, Chris On 9/21/2022 1:26 AM, Gerd Hoffmann wrote: On Tue, Sep 20, 2022 at 01:01:04PM -0700, Chris Fernald wro

Re: [edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-21 Thread Chris Fernald
Similar to my comment about the assumption in use of python, I believe the container should be determined and passed in as a parameter from the top level pipeline file rather then relying on tool chain tag. This lets the templates take action on being containerized rather then assuming the tool

Re: [edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-21 Thread Gerd Hoffmann
On Tue, Sep 20, 2022 at 01:01:04PM -0700, Chris Fernald wrote: > Similar to my comment about the assumption in use of python, I believe the > container should be determined and passed in as a parameter from the top > level pipeline file rather then relying on tool chain tag. This lets the > templat

[edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-20 Thread Oliver Steffen
Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run