OK
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, March 18, 2022 9:59 AM
> To: Li, Zhihao ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
> Jiang, Guomin ; Fu, Siyuan ;
> Yao, Jiewen
> Subject: RE: [PATCH v6 1/1] CryptoPkg: Add new hash algorithm
>
Yes. It seems we missed RsaPssSign and RsaPssVerify in previous patch. Sigh...
Would you please help to add them?
> -Original Message-
> From: Li, Zhihao
> Sent: Friday, March 18, 2022 9:53 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
> Jiang, Guomin
Build CryptoPei and CryptoSmm driver report this error.
INFO - /home/vsts/work/1/s/CryptoPkg/Driver/Crypto.c:4707:3: error:
initialization of 'BOOLEAN (__attribute__((ms_abi)) *)(void *, const UINT8 *,
UINTN, UINT16, UINT16, UINT8 *, UINTN *)' from incompatible pointer type
'BOOLEAN
What is root cause of failure?
I don't understand.
> -Original Message-
> From: Li, Zhihao
> Sent: Friday, March 18, 2022 12:27 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
> Jiang, Guomin ; Fu, Siyuan
> Subject: RE: [PATCH v6 1/1] CryptoPkg: Add new
Because it will cause patch to fail in CI test while to succeed if follow the
setting.
Failed test: https://github.com/tianocore/edk2/pull/2535
I guess it's because data structure EDKII_CRYPTO_PROTOCOL( mEdkiiCrypto)
doesn't have /// RSA PSS members in Crypto.c
> -Original Message-
>
Hey
Are you following the guideline - don't put new field in the middle ?
ParallelHash256HashAll API is still in the middle..
> @@ -3641,6 +3670,8 @@ struct _EDKII_CRYPTO_PROTOCOL {
>EDKII_CRYPTO_TLS_GET_HOST_PUBLIC_CERT TlsGetHostPublicCert;
>
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3596
Parallel hash function ParallelHash256HashAll, as defined in NIST's
Special Publication 800-185, published December 2016. It utilizes
multi-process to calculate the digest.
Passed CI test.
Onprotocol version code passed test.
Cc: Jiewen
