Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-07-10 Thread Michael D Kinney
Liming, GccInline.c can be used in UnitTestHostBaseLib instance. GccInlinePriv.c is the file that cannot be used in the. UnitTestHostBaseLib instance. Here are the grep results in the branch: baselib.inf: Ia32/GccInline.c | GCC baselib.inf: Ia32/GccInlinePriv.c | GCC baselib.inf:

Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-07-10 Thread Liming Gao
Mike: So, GccInline.c file can't be used in the unit test BaseLib. Thanks Liming -Original Message- From: Kinney, Michael D Sent: 2020年7月10日 1:01 To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael D Cc: Sean Brogan ; Bret Barkelew ; Yao, Jiewen Subject: RE: [Patch 04/15]

Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-07-09 Thread Michael D Kinney
Liming, In order to support host based unit tests, all the code has to be compatible with a user mode process. This means any functions that execute instructions that are not allowed in a user mode process need to be separated out. For the IA32/X64 specific GccInline.c files, the analysis was

Re: [edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-07-09 Thread Liming Gao
Mike: Is there the rule to know which function can't be in unit test? And, those functions will be in GccInline.c or GccInlinePriv.c? There is no change in MSFT C source file, because MSFT C source file has been separated as the function level. Right? Thanks Liming > -Original

[edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2800 Break out the IA32/X64 GCC inline functions that can not be used in a unit test host application into their own source file. This does not make any changes to the BaseLib library instance. This is in preparation for a new BaseLib instances