Re: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-13 Thread Bob Feng
12, 2021 6:31 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Feng, Bob C ; Chen, Christine > > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: > MAKE_FLAGS and MAKE_PATH fixes > > Mike: > I don't see the issue in the code change.

Re: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-12 Thread Michael D Kinney
s.io; Kinney, Michael D > Cc: Feng, Bob C ; Chen, Christine > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS > and MAKE_PATH fixes > > Mike: > I don't see the issue in the code change. I want to know what unit test > has been done for this chan

回复: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-12 Thread gaoliming
ao > ; Yuwei Chen > 主题: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS > and MAKE_PATH fixes > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3312 > > Update parsing of MAKE_FLAGS in DSC [BuildOptions] sections > to split the flags into a list to be c

Re: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-11 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: Kinney, Michael D > Sent: Saturday, April 10, 2021 5:49 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Liming Gao > ; Chen, Christine > Subject: [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and > MAKE_PATH fixes > > REF: https

[edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3312 Update parsing of MAKE_FLAGS in DSC [BuildOptions] sections to split the flags into a list to be compatible with running the make command using Popen(). Parsing MAKE_FLAGS from tools_def.txt already uses _SplitOption(). This change uses th