Re: [edk2-devel] [Patch 1/1] ShellPkg/Shell: Do not set end device path if already end

2022-12-13 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/3744 Commit: https://github.com/tianocore/edk2/commit/592bf33a29360e8a447ed8b75daefe94c0888642 Mike > -Original Message- > From: Gao, Zhichao > Sent: Sunday, December 11, 2022 11:17 PM > To: Ard Biesheuvel ; Kinney, Michael D > > Cc: dev

Re: [edk2-devel] [Patch 1/1] ShellPkg/Shell: Do not set end device path if already end

2022-12-11 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Ard Biesheuvel > Sent: Saturday, December 10, 2022 1:44 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > Subject: Re: [Patch 1/1] ShellPkg/Shell: Do not set end device path if alread

Re: [edk2-devel] [Patch 1/1] ShellPkg/Shell: Do not set end device path if already end

2022-12-09 Thread Ard Biesheuvel
On Fri, 9 Dec 2022 at 17:00, Michael D Kinney wrote: > > Update Shell Protocol EfiShellGetMapFromDevicePath() to not > set the end if the device path if it is already an end of > entire device path. This removes a write oprtation that can > cause failures if the Device Path Protocol is mapped to

[edk2-devel] [Patch 1/1] ShellPkg/Shell: Do not set end device path if already end

2022-12-09 Thread Michael D Kinney
Update Shell Protocol EfiShellGetMapFromDevicePath() to not set the end if the device path if it is already an end of entire device path. This removes a write oprtation that can cause failures if the Device Path Protocol is mapped to read-only memory. In general Device Path Protocols should not b