Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-23 Thread duntan
Hi Liming, Could you please help to review the following 2 patches in the patch series? [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thanks, Dun From: Ni, Ray Sent:

Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-23 Thread Wu, Jiaxin
Series Reviewed-by: Jiaxin Wu The series patches are good to me now. Thanks Dun. Thanks, Jiaxin > -Original Message- > From: Tan, Dun > Sent: Friday, May 17, 2024 5:46 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Wu, Jiaxin > ; Ni, Ray ; Ard Biesheuvel > ; Yao, Jiewen ; Gerd >

Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-20 Thread Ni, Ray
Following 3 patches still require the Reviewed-by from package maintainers of MdeModulePkg and OvmfPkg. MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE The patch set is a good move to

[edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-17 Thread duntan
Comparing to V1 patchs set, the V2 patch set only adjusts the commits ordering and modifies copy right year in some files. This patch set is to remove some S3 related code in CpuS3.c of smm cpu driver. It contain commits to: 1) S3 MTRRs operation: > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid >