Re: [edk2-devel] [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

2023-03-14 Thread duntan
Okay, I'll split this patch into 2 patches in next version Thanks, Dun -Original Message- From: Ni, Ray Sent: Wednesday, March 15, 2023 9:28 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 03/14]

Re: [edk2-devel] [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

2023-03-14 Thread Ni, Ray
Dun, Can you split this patch to 2 patches? One to move some local variable initialization to the beginning of the function. The other to fix the bug. So the bug fix changes look smaller. Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To:

[edk2-devel] [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

2023-03-08 Thread duntan
In previous code logic, when splitting a leaf parent entry to smaller granularity child page table, if the parent entry Attribute(without PageTableBaseAddress field) is equal to the input attribute(without PageTableBaseAddress field), the split process won't happen. This may lead to failure in