Re: [edk2-devel] [Patch V2 05/14] UefiCpuPkg/CpuPageTebleLib: Check Mask and Attr in PageTableMap

2023-03-15 Thread duntan
Thanks for the comments. Will do the code change in next version patch set. Thanks, Dun -Original Message- From: Ni, Ray Sent: Wednesday, March 15, 2023 1:34 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 05/14] UefiCpuPkg/

Re: [edk2-devel] [Patch V2 05/14] UefiCpuPkg/CpuPageTebleLib: Check Mask and Attr in PageTableMap

2023-03-14 Thread Ni, Ray
> +**/ > +RETURN_STATUS > +CheckMaskAndAttrForNotPresentEntry ( > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > + ) > +{ > + if ((Attribute->Bits.Present == 0) || (Mask->Bits.Present == 0) || (Mask- > >Bits.ReadWrite == 0) || 1. I think we can allow caller to

[edk2-devel] [Patch V2 05/14] UefiCpuPkg/CpuPageTebleLib: Check Mask and Attr in PageTableMap

2023-03-08 Thread duntan
When creating new page table or mapping not-present range in existing page table, we need to make sure all the non-reserved fields of input Mask are not 0 and Present field of input Attribute is 1. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuP