Re: [edk2-devel] [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

2023-03-15 Thread duntan
I'll add more comments and modify the code to set 4 PDPTE entries. Also will add unit test code check the MustBeZero fields for PAE paging. Thanks for the comments. Thanks, Dun -Original Message- From: Ni, Ray Sent: Wednesday, March 15, 2023 2:24 PM To: Tan, Dun ; devel@edk2.groups.io

Re: [edk2-devel] [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

2023-03-15 Thread Ni, Ray
> +if (PagingMode == PagingPae) { > + // > + // These fields of PAE paging PDPTE should be 0 according to SDM. > + // 1. can you update comments to explain such as: "These fields are treated as ReadWrite, by the common map logic. So they might be set to 1." > +

[edk2-devel] [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

2023-03-08 Thread duntan
Remove the limitation check for PagingPae to enable creating or updating PAE page table in CpuPageTableLib. The origin code is naturally adapted for PAE paging. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann ---