Hoffmann
> Sent: Tuesday, February 21, 2023 5:26 PM
> To: devel@edk2.groups.io; Xie, Yuanhao
> Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean
> ; Lu, James ; Guo, Gua
>
> Subject: Re: [edk2-devel] [Patch V2 2/5] UefiCpuPkg: Contiguous memory
> allocation and code clean-up.
>
Sean
; Lu, James ; Guo, Gua
Subject: Re: [edk2-devel] [Patch V2 2/5] UefiCpuPkg: Contiguous memory
allocation and code clean-up.
Hi,
> + Address= BASE_4GB - 1;
Why do you set Address here ...
> + Status = gBS->AllocatePages (
> +
Hi,
> + Address= BASE_4GB - 1;
Why do you set Address here ...
> + Status = gBS->AllocatePages (
> + AllocateMaxAddress,
> + EfiReservedMemoryType,
> + StackPages+FuncPages,
> +
> + );
... when it is
Allocate the memory for stacks and APs loop at contiguous address. The
memory is calculated taking into account the size difference of
RelocateApLoopFunc under different cases.
This patch also includes the code refactoring to eliminate the
duplication, non-descriptive variable, etc.
Cc: Guo Dong
