Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-13 Thread Jordan Justen
On 2019-06-11 22:42:13, Liu, Zhiguang wrote: > Thanks for the comments. > I will change the commit message in the next version. > But I don't think this is a issue worth making a major change. > Given that the change is consistent with NT32, will you agree with this > change? Hmm. You are right

Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Zhiguang Liu
Thanks for the comments. I will change the commit message in the next version. But I don't think this is a issue worth making a major change. Given that the change is consistent with NT32, will you agree with this change? Best Regards, Zhiguang Liu >-Original Message- >From: Justen,

Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Jordan Justen
On 2019-06-11 00:32:27, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1686 > > V3: I hope that changing the status of the mCpuSmbiosType4 > wouldn't affect other features except showing CPU speed. > The value is zero in NT32Pkg. > > Cc: Jordan Justen >

[edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed

2019-06-11 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1686 V3: I hope that changing the status of the mCpuSmbiosType4 wouldn't affect other features except showing CPU speed. The value is zero in NT32Pkg. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Zhiguang Liu ---