Jordan,
Thanks. Yes. Updating the Author sounds like the
right fix. I will send an updated series soon.
Thanks,
Mike
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, August 16, 2019 11:21 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Ni, Ray ; Andrew Fish
>
On 2019-08-16 08:09:55, Kinney, Michael D wrote:
> Jordan,
>
> It is not a typo.
>
> Andrew generated the XCODE specific changes, so they have
> been tested by him.
In that case, is the git author for the patches set to Andrew? If it
was, I would expect to see a line inside the email body
Tested-by: Andrew Fish
I tested the XCODE builds of the emulator and made sure that source level
debugging worked probably for builds that generate symbols.
Thanks,
Andrew Fish
> On Aug 16, 2019, at 8:09 AM, Michael D Kinney
> wrote:
>
> Jordan,
>
> It is not a typo.
>
> Andrew
Jordan,
It is not a typo.
Andrew generated the XCODE specific changes, so they have
been tested by him. I have also reviewed and tested the XCODE
changes and verified that all 6 combinations build and boot
to shell (IA32/X64 for RELEASE/DEBUG/NOOPT). Since they are
all related to making
On 2019-08-15 19:14:33, Michael D Kinney wrote:
> Fix scripts to support lldb symbolic debugging when
> using XCODE5 tool chain.
>
> Cc: Jordan Justen
> Cc: Ray Ni
> Cc: Michael D Kinney
> Signed-off-by: Andrew Fish
Is this a Cc/Signed-off-by typo? (See also, patches 7-10).
This makes me
Fix scripts to support lldb symbolic debugging when
using XCODE5 tool chain.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Unix/lldbefi.py | 8 +---
EmulatorPkg/build.sh| 17 ++---
2 files changed, 7 insertions(+), 18
