Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

2023-06-09 Thread duntan
: Gao, Liming ; Ni, Ray ; Wang, Jian J Subject: Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page On Thu, 8 Jun 2023 at 04:28, duntan wrote: > > Remove RO and NX protection when unset guard page. > When UnsetGuardPage(), remove all t

Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

2023-06-08 Thread Ard Biesheuvel
On Thu, 8 Jun 2023 at 04:28, duntan wrote: > > Remove RO and NX protection when unset guard page. > When UnsetGuardPage(), remove all the memory attribute protection > for guarded page. > Why is it acceptable to remove NX protections here? > Signed-off-by: Dun Tan > Cc: Liming Gao > Cc: Ray

Re: [edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

2023-06-08 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, June 8, 2023 10:28 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Ni, Ray ; > Wang, Jian J > Subject: [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection > when unset guard page > > Remove RO and NX

[edk2-devel] [Patch V5 02/14] MdeModulePkg: Remove RO and NX protection when unset guard page

2023-06-07 Thread duntan
Remove RO and NX protection when unset guard page. When UnsetGuardPage(), remove all the memory attribute protection for guarded page. Signed-off-by: Dun Tan Cc: Liming Gao Cc: Ray Ni Cc: Jian J Wang --- MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 2 +- 1 file changed, 1 insertion(+), 1