Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2024-02-27 Thread Michael D Kinney
higuang > ; Oliver Smith-Denny > ; Pop, Aaron > Subject: Re: [edk2-devel] [Patch v2 1/3] > MdePkg/Include/IndustryStandard: Add Operator and Xor field names > > On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney > wrote: > > > > Hi Pedro, > > > > L

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2024-02-27 Thread Pedro Falcato
On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney wrote: > > Hi Pedro, > > Looks like this series got set aside waiting for some additional feedback. Hi, This is odd, I did reply back in June (https://edk2.groups.io/g/devel/message/105817). You probably missed the email or maybe for some

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2024-02-27 Thread Michael D Kinney
Hi Pedro, Looks like this series got set aside waiting for some additional feedback. I would like to see this C++ Keyword issue resolved. Thanks, Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, June 6, 2023 10:57 AM > To: Pedro Falcato > Cc:

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-06-06 Thread Pedro Falcato
On Tue, Jun 6, 2023 at 6:57 PM Michael D Kinney wrote: > > Hi Pedro, > > Based on this info, would you prefer we use xor_ style instead of Xor? > > I can update the PR with that change. > > Mike Hi Mike, Sorry, I didn't know you were waiting for my input. Yes, I would prefer xor_ style, but I'll

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-06-06 Thread Michael D Kinney
Hi Pedro, Based on this info, would you prefer we use xor_ style instead of Xor? I can update the PR with that change. Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, June 1, 2023 8:02 AM > To: Pedro Falcato > Cc: devel@edk2.groups.io; Gao, Liming ; Liu, >

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-06-01 Thread Michael D Kinney
Hi Pedro, It appears other projects have run into this same issue with the TPM specifications and have changed the field names by appending '_'. https://github.com/MIPS/external-tpm2/blob/d704926273cf17498c95ff0dc50b4b17e523c109/generator/structure_generator.py#L1183 Mike > -Original

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-05-31 Thread Michael D Kinney
> -Original Message- > From: Pedro Falcato > Sent: Wednesday, May 31, 2023 11:17 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Gao, Liming ; Liu, > Zhiguang ; Oliver Smith-Denny > ; Pop, Aaron > Subject: Re: [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator > and

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-05-31 Thread Pedro Falcato
On Tue, May 30, 2023 at 7:53 PM Michael D Kinney wrote: > > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords > operator and xor in C structures to support use of these > include files when building with a C++ compiler. > > This patch temporarily introduces an anonymous union to add >

[edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2023-05-30 Thread Michael D Kinney
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. This patch temporarily introduces an anonymous union to add Operator and Xor fields to support migration from the current field