Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-12 Thread Abdul Lateef Attar via groups.io
Hi Pierre and Sami,     I'll submit separate patches for each table, which will be ready and easy to merge after the current hard feature freeze over. Thanks AbduL On 03-05-2024 13:11, Sami Mujawar wrote: Caution: This message originated from an External Source. Use proper caution when

Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-03 Thread Sami Mujawar
Hi All, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 02/05/2024, 17:36, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote: Hello Abdul, I added some comments. I think that: a. patches related to HPET/WSMT should require little work b. MADT patch needs to

Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-02 Thread PierreGondois
Hello Abdul, I added some comments. I think that: a. patches related to HPET/WSMT should require little work b. MADT patch needs to redefine the CmObjects it uses, but it seems ok otherwise (just need to have the right properties in the right objects), c. FADT patch is re-defining CmObjects

Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-02 Thread Abdul Lateef Attar via groups.io
Hi Pierre Gondois and Sami Mujawar,     Could you please review below patch set and consider for upcoming stable release ? There are non-disruptive patches and won't impact existing ARM platform. Thanks AbduL On 29-04-2024 11:33, Abdul Lateef Attar wrote: PR:

[edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-04-29 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2/pull/5500/ V4: delta changes Added X64 arch specific MADT table generator. V3: delta changes Restructure the code as the review comments. Added sanity check for WSMT flags. Added CM object for HPET base address. V2: delta changes Addressed review