Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-14 Thread Andrew Fish via Groups.Io
> On Oct 14, 2019, at 6:11 AM, Laszlo Ersek wrote: > > On 10/12/19 08:42, Andrew Fish wrote: >> Laszlo, >> >> For 2) this is very unfortunate. I think the root cause is for those >> of us who work on x86 hardware day to day we get programed that >> SEC/PEI is IA32 and DXE is X64, and this

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-14 Thread Laszlo Ersek
On 10/12/19 08:42, Andrew Fish wrote: > Laszlo, > > For 2) this is very unfortunate. I think the root cause is for those > of us who work on x86 hardware day to day we get programed that > SEC/PEI is IA32 and DXE is X64, and this can lead to some unfortunate > coding outcomes. First I was

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Andrew Fish via Groups.Io
l.com>>; Gao, Liming <mailto:liming@intel.com>>; Dong, Eric <mailto:eric.d...@intel.com>>; Ni, Ray <mailto:ray...@intel.com>>; Singh, Brijesh <mailto:brijesh.si...@amd.com>>; Philippe Mathieu-Daudé <mailto:phi...@redhat.com>> > Subjec

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Liming Gao
-Daudé Subject: Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES Laszlo, For 2) this is very unfortunate. I think the root cause is for those of us who work on x86 hardware day to day we get programed that SEC/PEI is IA32 and DXE is X64, and this can lead to some

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-12 Thread Andrew Fish via Groups.Io
Laszlo, For 2) this is very unfortunate. I think the root cause is for those of us who work on x86 hardware day to day we get programed that SEC/PEI is IA32 and DXE is X64, and this can lead to some unfortunate coding outcomes. I'm guessing this code probably got ported from the DXE CPU

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-11 Thread Laszlo Ersek
On 10/11/19 01:17, Lendacky, Thomas wrote: > On 10/3/19 10:12 AM, Tom Lendacky wrote: >> >> >> On 10/3/19 5:32 AM, Laszlo Ersek wrote: >>> On 10/03/19 12:12, Laszlo Ersek wrote: >>> UINT32 ApEntryPoint; EFI_GUID SevEsFooterGuid; UINT16 Size; >>> >>> It's probably better to

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-10 Thread Andrew Fish via Groups.Io
> On Oct 10, 2019, at 4:17 PM, Lendacky, Thomas wrote: > > On 10/3/19 10:12 AM, Tom Lendacky wrote: >> >> >> On 10/3/19 5:32 AM, Laszlo Ersek wrote: >>> On 10/03/19 12:12, Laszlo Ersek wrote: >>> UINT32 ApEntryPoint; EFI_GUID SevEsFooterGuid; UINT16 Size; >>> >>>

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-10 Thread Lendacky, Thomas
On 10/3/19 10:12 AM, Tom Lendacky wrote: > > > On 10/3/19 5:32 AM, Laszlo Ersek wrote: >> On 10/03/19 12:12, Laszlo Ersek wrote: >> >>> UINT32 ApEntryPoint; >>> EFI_GUID SevEsFooterGuid; >>> UINT16 Size; >> >> It's probably better to reverse the order of "Size" and >>

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Lendacky, Thomas
On 10/3/19 5:32 AM, Laszlo Ersek wrote: > On 10/03/19 12:12, Laszlo Ersek wrote: > >> UINT32 ApEntryPoint; >> EFI_GUID SevEsFooterGuid; >> UINT16 Size; > > It's probably better to reverse the order of "Size" and > "SevEsFooterGuid", like this: > > UINT32 ApEntryPoint; > UINT16

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/03/19 12:12, Laszlo Ersek wrote: > UINT32 ApEntryPoint; > EFI_GUID SevEsFooterGuid; > UINT16 Size; It's probably better to reverse the order of "Size" and "SevEsFooterGuid", like this: UINT32 ApEntryPoint; UINT16 Size; EFI_GUID SevEsFooterGuid; because then even the

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/02/19 20:07, Lendacky, Thomas wrote: > On 10/2/19 10:26 AM, Laszlo Ersek wrote: >> On 10/02/19 17:15, Laszlo Ersek wrote: >>> Adding Phil. >>> >>> I'm looking at this patch only because one thing caught my attention in >>> the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/02/19 19:58, Lendacky, Thomas wrote: > On 10/2/19 10:15 AM, Laszlo Ersek via Groups.Io wrote: >> Adding Phil. >> >> I'm looking at this patch only because one thing caught my attention in >> the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector >> re-directing": >> >> On

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-02 Thread Lendacky, Thomas
On 10/2/19 10:26 AM, Laszlo Ersek wrote: > On 10/02/19 17:15, Laszlo Ersek wrote: >> Adding Phil. >> >> I'm looking at this patch only because one thing caught my attention in >> the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector >> re-directing": >> >> On 09/19/19 21:53, Lendacky,

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-02 Thread Laszlo Ersek
On 10/02/19 17:15, Laszlo Ersek wrote: > Adding Phil. > > I'm looking at this patch only because one thing caught my attention in > the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector > re-directing": > > On 09/19/19 21:53, Lendacky, Thomas wrote: >> From: Tom Lendacky >> >> BZ:

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-02 Thread Laszlo Ersek
Adding Phil. I'm looking at this patch only because one thing caught my attention in the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector re-directing": On 09/19/19 21:53, Lendacky, Thomas wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >

[edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-09-19 Thread Lendacky, Thomas
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Typically, an AP is booted using the INIT-SIPI-SIPI sequence. This sequence is intercepted by the hypervisor, which sets the AP's registers to the values requested by the sequence. At that point, the hypervisor can start