Re: [edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-12-12 Thread Ni, Ray
yes. > -Original Message- > From: Tom Lendacky > Sent: Friday, December 13, 2019 4:48 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > ; Kinney, Michael D ; > Gao, Liming ; Dong, > Eric ; Brijesh Singh ; Wang, Jian > J ; Wu, Hao A > >

Re: [edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:53 AM, Ni, Ray wrote: > Do you really need to define the PCD in MdePkg? > General guide lines are: > 1. Avoid UefiCpuPkg depend on MdeModulePkg. > 2. Do not define platform level PCD in core pkgs (MdePkg, MdeModulePkg, > UefiCpuPkg, etc) > > > PcdSevEsIsEnabled seems to be used

Re: [edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-12-11 Thread Ni, Ray
Do you really need to define the PCD in MdePkg? General guide lines are: 1. Avoid UefiCpuPkg depend on MdeModulePkg. 2. Do not define platform level PCD in core pkgs (MdePkg, MdeModulePkg, UefiCpuPkg, etc) PcdSevEsIsEnabled seems to be used in OVMF pkg only so how about define that in

[edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-11-20 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Two new fixed PCSs are needed to support SEV-ES under OVMF: - PcdSecGhcbBase UINT64 value that is the base address of the GHCB used during the SEC phase. - PcdSecGhcbSize UINT64 value that is the size, in bytes, of