Thanks David. No more comments for this patch.
> -Original Message-
> From: Wei, David Y
> Sent: Thursday, August 22, 2019 3:31 PM
> To: Kubacki, Michael A ; devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Desimone, Nathaniel L
> ; Kinney, Michael
Hi Mike,
Please see the updates online below. Please let me know if you have any more
comments.
Thanks
David
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 19, 2019 6:04 PM
To: Wei, David Y ; devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha,
Ankit ; Agyeman,
Feedback I could not find already noted elsewhere:
1. Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c:
There's some style issues throughout the file related to a missing space
before opening parenthesis and parameters than span multiple lines.
Some of these are pre-existing in
Hi David,
Here are my comments:
1. All of the copyright years need to be updated to 2019.
2. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0"
from your commit message as it is no longer needed.
3. Silicon/Intel/SimicsX58SktPkg/Override/UefiCpuPkg/SecCore/SecMain.c -
Add CPU Pkg for SimicsX58. It is added for simics QSP project support
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
