Re: [edk2-devel] [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol

2023-02-16 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Isaac, Thanks for spending time on this. Please see my feedback below, > -Original Message- > From: Oram, Isaac W > Sent: Thursday, February 16, 2023 9:42 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Gao, Liming ; Desimone, Nathaniel L > ; Nickl

Re: [edk2-devel] [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol

2023-02-15 Thread Isaac Oram
In looking at the code, this is what I see: edk2: There is an IpmiLib.h library class which abstracts the IpmiPpi.h/IpmiProtocol.h use There is an IpmiPpi.h/IpmiProtocol.h which provide an interface to send a command "via IPMI" Current IpmiPpi.h/IpmiProtocol.h implementat

[edk2-devel] [edk2-platforms][PATCH 0/7] Implementation of IPMI Protocol

2023-02-07 Thread Chang, Abner via groups.io
From: Abner Chang This change implementes IPMI Protocol and PPI in the new introduced ManageabilityPkg (described in below email) https://edk2.groups.io/g/devel/message/95579?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2CManageability%2C20%2C2%2C0%2C94572748 BZ #4336: The change also fixes the con