Re: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-30 Thread wangy
Hi Pedro Falcato, At 2023-07-29 03:40:15, "Pedro Falcato" wrote: >On Fri, Jul 28, 2023 at 5:00 AM wangy wrote: >> >> From: Yang Wang >> >> If IrqStat is NULL, the interrupt status will not be >> read from the device.When the interrupt status is read, >> it will also be cleared. > >Let's

Re: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-29 Thread Ard Biesheuvel
On Fri, 28 Jul 2023 at 21:40, Pedro Falcato wrote: > > On Fri, Jul 28, 2023 at 5:00 AM wangy wrote: > > > > From: Yang Wang > > > > If IrqStat is NULL, the interrupt status will not be > > read from the device.When the interrupt status is read, > > it will also be cleared. > > Let's improve the

Re: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-28 Thread Pedro Falcato
On Fri, Jul 28, 2023 at 5:00 AM wangy wrote: > > From: Yang Wang > > If IrqStat is NULL, the interrupt status will not be > read from the device.When the interrupt status is read, > it will also be cleared. Let's improve the commit message a bit, something like: The EFI spec (see UEFI 2.10,

[edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-27 Thread wangy
From: Yang Wang If IrqStat is NULL, the interrupt status will not be read from the device.When the interrupt status is read, it will also be cleared. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Ran Wang Signed-off-by: Yang Wang --- .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c| 22