[AMD Official Use Only - General]
Hi Nickle, I will fix them in the next version.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, April 20, 2023 2:42 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Igor Kulchy
[AMD Official Use Only - General]
Hi Abdul,
I don't use EFIAPI is because this is a library linked with the module, so
there is no calling convention problem.
However, I should have a consistent coding style for this file. I will update
this file and remove EFIAPI for other functions.
Thanks
Ab
[AMD Official Use Only - General]
Comments inline.
-Original Message-
From: Chang, Abner
Sent: 18 April 2023 12:46
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V2 01/14] ManageabilityPkg: A
Hi Abner,
Please find my comments below.
Thanks,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, April 18, 2023 3:16 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Abdul Lateef Attar
> ; Nickle Wang ; Igor Kulchytskyy
>
> Subject: [edk2-platforms][PATCH V2 01
From: Abner Chang
1. Add a helper function to output payload binary
to debug output device.
2. Add a helper function to split payload into
packages according to maximum transfer unit
of transport interface.
3. Add a helper function to generate CRC8.
Signed-off-by: Abner Chang
Cc: Isaac
