Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

2023-06-30 Thread Isaac Oram
sai V ; Oram, Isaac W ; S, Ashraf Ali Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup From: Michael Kubacki During a review of this driver a number of improvements were noted such as strengthening function input validation, ch

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

2023-06-30 Thread Isaac Oram
it. Regards, Isaac -Original Message- From: S, Ashraf Ali Sent: Friday, June 30, 2023 11:57 AM To: devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbSer

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

2023-06-30 Thread Ashraf Ali S
Reviewed-by: Ashraf Ali S -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Friday, June 30, 2023 8:03 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1

[edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

2023-06-29 Thread Michael Kubacki
From: Michael Kubacki During a review of this driver a number of improvements were noted such as strengthening function input validation, checking return values, making debug print error levels consistent in certain code blocks, etc. These type of changes are made with no explicit change to