[edk2-devel] [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker fixes

2024-07-17 Thread Michael Kubacki
From: Michael Kubacki Some code is currently not being built in the package. This fixes GCC compiler errors and MSVC linker failures in the code so the package can build with these modules included. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Ashraf Ali S Co-authored-by: Ken Lautner Signed-off-b

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker fixes

2024-07-17 Thread Ashraf Ali S
] [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker fixes From: Michael Kubacki Some code is currently not being built in the package. This fixes GCC compiler errors and MSVC linker failures in the code so the package can build with these modules included. Cc: Ray Ni Cc

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker fixes

2024-07-17 Thread Chaganty, Rangasai V
Hi Michael, Thanks for addressing the GCC compiler issues. Overall looks good. In IntelVTdCorePei.c, it seems the following got missed: Item->Header.LogType = (UINT64) (1 << EventType); Can you also take care of below and use LShiftU64, instead of compiler intrinsic operators. Thanks, Sa

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker fixes

2024-07-18 Thread Michael Kubacki
Thanks for finding those. Updated them in V2: - https://edk2.groups.io/g/devel/message/119967 - https://github.com/tianocore/edk2-platforms/pull/171 On 7/18/2024 12:15 AM, Chaganty, Rangasai V wrote: Hi Michael, Thanks for addressing the GCC compiler issues. Overall looks good. In IntelVTdCore