[edk2-devel] [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances

2021-05-18 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform design in edk2-platforms. I'm planning to build some additional functionality on top of SpiFlashCommonLib and, ideally, this duplication will be

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances

2021-05-21 Thread Nate DeSimone
Thank Michael, I was able to get the new patch series to apply. For the series... Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, May 18, 2021 8:59 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ;

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances

2021-05-26 Thread Nate DeSimone
Hi Michael, I have been thinking about this more from a long-term maintainability standpoint. The IFWI region enum FLASH_REGION_TYPE looks pretty ripe for causing issues years from now. We should probably convert each member of that enum into a EFI_GUID so that regions can be added/removed as n

Re: [edk2-devel] [edk2-platforms][PATCH v2 00/35] Consolidate SpiFlashCommonLib instances

2021-05-27 Thread Michael Kubacki
Hi Nate, I am out of office most of this week and I will look into that next week. Would you consider that a requirement to extend onto this patch series? Or could it be a follow up series? Asking due to to the length of this series. Thanks, Michael On 5/26/2021 4:57 PM, Desimone, Nathaniel