Re: [edk2-devel] [edk2-platforms][PATCH v3 01/11] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent

2023-01-27 Thread Marvin Häuser
Reviewed-by: Marvin Häuser mailto:mhaeu...@posteo.de>> > On 27. Jan 2023, at 15:12, Pedro Falcato wrote: > > On Fri, Jan 27, 2023 at 9:29 AM Savva Mitrofanov wrote: >> >> We need to free buffer on return if BlockRemainder != 0. Also changed >> return logic from function to use use common exit

Re: [edk2-devel] [edk2-platforms][PATCH v3 01/11] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent

2023-01-27 Thread Pedro Falcato
On Fri, Jan 27, 2023 at 9:29 AM Savva Mitrofanov wrote: > > We need to free buffer on return if BlockRemainder != 0. Also changed > return logic from function to use use common exit to prevent code > duplication. > > Cc: Marvin Häuser > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: d9ceedca6

[edk2-devel] [edk2-platforms][PATCH v3 01/11] Ext4Pkg: Fix memory leak in Ext4RetrieveDirent

2023-01-27 Thread Savva Mitrofanov
We need to free buffer on return if BlockRemainder != 0. Also changed return logic from function to use use common exit to prevent code duplication. Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov ---